sijie commented on a change in pull request #4174: [go function] support
localrun and cluster mode for go function
URL: https://github.com/apache/pulsar/pull/4174#discussion_r279606811
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -501,13 +511,13 @@ protected void validateFunctionConfigs(FunctionConfig
functionConfig) {
org.apache.pulsar.common.functions.Utils.inferMissingNamespace(functionConfig);
}
- if (isNotBlank(functionConfig.getJar()) &&
isNotBlank(functionConfig.getPy())) {
- throw new ParameterException("Either a Java jar or a Python
file needs to"
+ if (isNotBlank(functionConfig.getJar()) &&
isNotBlank(functionConfig.getPy()) && isNotBlank(functionConfig.getGo())) {
+ throw new ParameterException("Either a Java jar or a Python
file or a Go file needs to"
Review comment:
I would suggest using "Go executable binary" rather than "Go file". A "Go
file" is a bit confusing, since it typically means the source files suffixed
with `.go`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
