momo-jun commented on code in PR #16917: URL: https://github.com/apache/pulsar/pull/16917#discussion_r963312345
########## conf/broker.conf: ########## @@ -1497,12 +1497,22 @@ transactionCoordinatorEnabled=false transactionMetadataStoreProviderClassName=org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider # Transaction buffer takes a snapshot after the number of transaction operations reaches this value. +# If transaction buffer enables snapshot segment, transaction buffer updates snapshot metadata +# after the number of transaction operations reaches this value. transactionBufferSnapshotMaxTransactionCount=1000 -# Transaction buffer take snapshot interval time +# Transaction buffer take snapshot interval time. +# If transaction buffer enables snapshot segment, this is transaction updating snapshot metadata internal time. Review Comment: ```suggestion # If transaction buffer enables snapshot segment, it is the interval time for transaction buffer to update snapshot metadata. ``` ########## conf/broker.conf: ########## @@ -1497,12 +1497,22 @@ transactionCoordinatorEnabled=false transactionMetadataStoreProviderClassName=org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider # Transaction buffer takes a snapshot after the number of transaction operations reaches this value. +# If transaction buffer enables snapshot segment, transaction buffer updates snapshot metadata +# after the number of transaction operations reaches this value. transactionBufferSnapshotMaxTransactionCount=1000 -# Transaction buffer take snapshot interval time +# Transaction buffer take snapshot interval time. Review Comment: ```suggestion # The interval time for transaction buffer to take snapshots. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
