congbobo184 commented on code in PR #16917:
URL: https://github.com/apache/pulsar/pull/16917#discussion_r969082782
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2731,15 +2731,34 @@ public class ServiceConfiguration implements
PulsarConfiguration {
@FieldContext(
category = CATEGORY_TRANSACTION,
doc = "Transaction buffer take snapshot transaction count"
+ + "If transaction buffer enables snapshot segment,
transaction buffer updates snapshot metadata"
+ + "after the number of transaction operations reaches this
value."
)
private int transactionBufferSnapshotMaxTransactionCount = 1000;
@FieldContext(
category = CATEGORY_TRANSACTION,
- doc = "Transaction buffer take snapshot min interval time"
+ doc = "The interval time for transaction buffer to take snapshots."
+ + "If transaction buffer enables snapshot segment, "
+ + "it is the interval time for transaction buffer to
update snapshot metadata."
)
private int transactionBufferSnapshotMinTimeInMillis = 5000;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "Transaction buffer stores the transaction ID of aborted
transactions and takes snapshots."
+ + "This configuration determines the size of the snapshot
segment. "
+ + "The default value is 256 KB (262144 bytes)."
+ )
+ private int transactionBufferSnapshotSegmentSize = 262144;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
Review Comment:
```suggestion
category = CATEGORY_TRANSACTION,
```
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2731,15 +2731,34 @@ public class ServiceConfiguration implements
PulsarConfiguration {
@FieldContext(
category = CATEGORY_TRANSACTION,
doc = "Transaction buffer take snapshot transaction count"
+ + "If transaction buffer enables snapshot segment,
transaction buffer updates snapshot metadata"
+ + "after the number of transaction operations reaches this
value."
)
private int transactionBufferSnapshotMaxTransactionCount = 1000;
@FieldContext(
category = CATEGORY_TRANSACTION,
- doc = "Transaction buffer take snapshot min interval time"
+ doc = "The interval time for transaction buffer to take snapshots."
+ + "If transaction buffer enables snapshot segment, "
+ + "it is the interval time for transaction buffer to
update snapshot metadata."
)
private int transactionBufferSnapshotMinTimeInMillis = 5000;
+ @FieldContext(
+ category = CATEGORY_SERVER,
Review Comment:
```suggestion
category = CATEGORY_TRANSACTION,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
