asafm commented on code in PR #17041:
URL: https://github.com/apache/pulsar/pull/17041#discussion_r963701217


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java:
##########
@@ -1522,6 +1524,81 @@ public void testSplitTopicAndPartitionLabel() throws 
Exception {
         consumer2.close();
     }
 
+
+    @Test
+    public void testMetadataStoreStats() throws Exception {

Review Comment:
   Why moving `testMetadataStoreStats` to a new class called 
`MetadataStoreStatsTest` will prevent you from ensuring all metrics outputs as 
expected?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to