BewareMyPower commented on code in PR #17439:
URL: https://github.com/apache/pulsar/pull/17439#discussion_r964931914
##########
pulsar-client-cpp/include/pulsar/ProducerConfiguration.h:
##########
@@ -501,6 +506,12 @@ class PULSAR_PUBLIC ProducerConfiguration {
*/
bool isChunkingEnabled() const;
+ ProducerConfiguration& setAccessMode(const ProducerAccessMode& mode);
+
+ ProducerAccessMode getAccessMode() const;
+
+ bool isLazyStartPartitionedProducers() const;
Review Comment:
Unfortunately we already have `getLazyStartPartitionedProducers`, though the
name might not be good. Please don't introduce a new getter.
##########
pulsar-client-cpp/include/pulsar/ProducerConfiguration.h:
##########
@@ -501,6 +506,12 @@ class PULSAR_PUBLIC ProducerConfiguration {
*/
bool isChunkingEnabled() const;
+ ProducerConfiguration& setAccessMode(const ProducerAccessMode& mode);
+
+ ProducerAccessMode getAccessMode() const;
Review Comment:
Please add the API docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
