BewareMyPower commented on code in PR #17439:
URL: https://github.com/apache/pulsar/pull/17439#discussion_r965583109
##########
pulsar-client-cpp/lib/ProducerConfiguration.cc:
##########
@@ -211,7 +211,7 @@ ProducerConfiguration&
ProducerConfiguration::setLazyStartPartitionedProducers(
}
bool ProducerConfiguration::getLazyStartPartitionedProducers() const {
- return impl_->useLazyStartPartitionedProducers;
+ return impl_->useLazyStartPartitionedProducers && impl_->accessMode ==
Shared;
Review Comment:
It's a trivial getter, we should not check other fields. Instead, we should
call these two getters in `PartitionedProducerImpl` like
https://github.com/apache/pulsar/blob/2848fa0da09e035951220c3d04138041e1477e60/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedProducerImpl.java#L91-L92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
