codelipenghui commented on code in PR #17852:
URL: https://github.com/apache/pulsar/pull/17852#discussion_r981854169
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java:
##########
@@ -129,6 +135,8 @@ public static void generate(PulsarService pulsar, boolean
includeTopicMetrics, b
}
out.write(buf.array(), buf.arrayOffset(), buf.readableBytes());
} finally {
+ //release all the metrics buffers
+ metricStreams.releaseAll();
Review Comment:
@tjiuming I noticed you had removed the `exceptionHappens`, if we don't have
the check, will we release the `buf` multiple times?
From the master branch:
```
} catch (Throwable t) {
exceptionHappens = true;
throw t;
} finally {
//release all the metrics buffers
metricStreams.releaseAll();
//if exception happens, release buffer
if (exceptionHappens) {
buf.release();
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
