codelipenghui commented on code in PR #17852:
URL: https://github.com/apache/pulsar/pull/17852#discussion_r981921351
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java:
##########
@@ -129,6 +135,8 @@ public static void generate(PulsarService pulsar, boolean
includeTopicMetrics, b
}
out.write(buf.array(), buf.arrayOffset(), buf.readableBytes());
} finally {
+ //release all the metrics buffers
+ metricStreams.releaseAll();
Review Comment:
@tjiuming will the `buf` can get a chance to be released multiple times?
Since the `metricStreams.releaseAll()` will also get a chance to release the
`buf`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
