shibd commented on code in PR #17318:
URL: https://github.com/apache/pulsar/pull/17318#discussion_r981898474
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java:
##########
@@ -97,6 +98,9 @@
protected volatile Timeout batchReceiveTimeout = null;
protected final Lock reentrantLock = new ReentrantLock();
+ // Only work when subscription type is Failover or Exclusive
+ protected final Lock incomingQueueLock;
Review Comment:
> @codelipenghui We must let the redeliver clear incomingQueue in the user
thread, otherwise the redeliver will be meaningless, and you may still receive
messages before the incomingQueue is cleared.
Yes, So, Even if running in `internalPinned` thread, it still needs to be
blocked. Please refer to the latest changes. @codelipenghui @congbobo184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
