shibd commented on code in PR #17318:
URL: https://github.com/apache/pulsar/pull/17318#discussion_r990986619
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageRedeliveryTest.java:
##########
@@ -309,21 +303,110 @@ public void testRedeliveryAddEpoch(boolean enableBatch)
throws Exception{
message = consumer.receive(3, TimeUnit.SECONDS);
assertNull(message);
- Field field =
consumer.getClass().getDeclaredField("connectionHandler");
- field.setAccessible(true);
- ConnectionHandler connectionHandler = (ConnectionHandler)
field.get(consumer);
-
- field =
connectionHandler.getClass().getDeclaredField("CLIENT_CNX_UPDATER");
- field.setAccessible(true);
-
+ ConnectionHandler connectionHandler = consumer.getConnectionHandler();
connectionHandler.cnx().channel().close();
- ((ConsumerImpl<String>) consumer).grabCnx();
+ consumer.grabCnx();
+
message = consumer.receive(3, TimeUnit.SECONDS);
assertNotNull(message);
assertEquals(message.getValue(), test3);
}
+ @Test(dataProvider = "enableBatch")
+ public void testRedeliveryAddEpochAndPermits(boolean enableBatch) throws
Exception {
+ final String topic = "testRedeliveryAddEpochAndPermits";
+ final String subName = "my-sub";
+ // set receive queue size is 4, and first send 4 messages,
+ // then call redeliver messages, assert receive msg num.
+ int receiveQueueSize = 4;
+ ConsumerImpl<String> consumer = ((ConsumerImpl<String>)
pulsarClient.newConsumer(Schema.STRING)
+ .topic(topic)
+ .receiverQueueSize(receiveQueueSize)
+ .autoScaledReceiverQueueSizeEnabled(false)
+ .subscriptionName(subName)
+ .subscriptionType(SubscriptionType.Failover)
+ .subscribe());
+
+ Producer<String> producer = pulsarClient.newProducer(Schema.STRING)
+ .topic(topic)
+ .enableBatching(enableBatch)
+ .create();
+
+ consumer.setConsumerEpoch(1);
+ for (int i = 0; i < receiveQueueSize; i++) {
+ producer.send("pulsar" + i);
+ }
+ assertNull(consumer.receive(1, TimeUnit.SECONDS));
+
+ consumer.redeliverUnacknowledgedMessages();
+ for (int i = 0; i < receiveQueueSize; i++) {
+ Message<String> msg = consumer.receive();
+ assertEquals("pulsar" + i, msg.getValue());
+ }
+ }
+
+ @Test(dataProvider = "enableBatch")
+ public void testBatchReceiveRedeliveryAddEpoch(boolean enableBatch) throws
Exception{
Review Comment:
Thank your reminder, I added it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
