zymap commented on a change in pull request #4247: [WIP] PIP-36: Support set 
message size in broker.conf
URL: https://github.com/apache/pulsar/pull/4247#discussion_r282733023
 
 

 ##########
 File path: 
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java
 ##########
 @@ -218,7 +218,8 @@ private void completeConnect() {
             // partitions metadata lookups
             state = State.ProxyLookupRequests;
             lookupProxyHandler = new LookupProxyHandler(service, this);
-            
ctx.writeAndFlush(Commands.newConnected(protocolVersionToAdvertise));
+            ctx.writeAndFlush(
+                Commands.newConnected(protocolVersionToAdvertise, 
service.getConfiguration().getMaxMessagesSize()));
 
 Review comment:
   Oh, right, proxy is a client of broker so it need receive the max message 
size from broker and adjust itself. Will fix

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to