zymap commented on a change in pull request #4247: [WIP] PIP-36: Support set
message size in broker.conf
URL: https://github.com/apache/pulsar/pull/4247#discussion_r283077572
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/DirectProxyHandler.java
##########
@@ -99,7 +99,8 @@ protected void initChannel(SocketChannel ch) throws
Exception {
ch.pipeline().addLast(TLS_HANDLER,
sslCtx.newHandler(ch.alloc()));
}
ch.pipeline().addLast("frameDecoder",
- new
LengthFieldBasedFrameDecoder(PulsarDecoder.MaxFrameSize, 0, 4, 0, 4));
+ new
LengthFieldBasedFrameDecoder(config.getMaxMessagesSize() + 10 * 1024, 0, 4, 0,
Review comment:
I put the `FRAME_PADDING` into `InternalConfigurationData`, I think it's a
configuration so it's more suit to set in `InternalConfigurationData`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
