zymap commented on a change in pull request #4247: [WIP] PIP-36: Support set
message size in broker.conf
URL: https://github.com/apache/pulsar/pull/4247#discussion_r283081152
##########
File path:
pulsar-discovery-service/src/main/java/org/apache/pulsar/discovery/service/ServerConnection.java
##########
@@ -101,7 +102,7 @@ protected void handleConnect(CommandConnect connect) {
return;
}
}
- ctx.writeAndFlush(Commands.newConnected(connect.getProtocolVersion()));
+ ctx.writeAndFlush(Commands.newConnected(connect.getProtocolVersion(),
ServiceConfig.MAX_MESSAGE_SIZE));
Review comment:
I think discovery service only for looking up service so it's doesn't need
set max message size, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
