BewareMyPower commented on code in PR #54:
URL: https://github.com/apache/pulsar-client-cpp/pull/54#discussion_r1000193417
##########
lib/ConsumerImpl.cc:
##########
@@ -37,15 +37,14 @@ namespace pulsar {
DECLARE_LOG_OBJECT()
-ConsumerImpl::ConsumerImpl(const ClientImplPtr client, const std::string&
topic,
- const std::string& subscriptionName, const
ConsumerConfiguration& conf,
- bool isPersistent,
+ConsumerImpl::ConsumerImpl(ClientImpl& client, const std::string& topic, const
std::string& subscriptionName,
Review Comment:
> The problem with this is that if you keep using a producer/consumer after
the client is already destroyed, you would have a segfault.
Actually not. See `TEST_P(ClientCloseTest, testShutdown)`.
> It seems this PR is included more changes than just the part of using a
map to keep track of producers/consumers disposal.
And yes. I think it needs another PR for this refactor. For this PR, I will
revert these unnecessary changes soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
