BewareMyPower commented on code in PR #54:
URL: https://github.com/apache/pulsar-client-cpp/pull/54#discussion_r1000244695
##########
lib/ConsumerImpl.cc:
##########
@@ -37,15 +37,14 @@ namespace pulsar {
DECLARE_LOG_OBJECT()
-ConsumerImpl::ConsumerImpl(const ClientImplPtr client, const std::string&
topic,
- const std::string& subscriptionName, const
ConsumerConfiguration& conf,
- bool isPersistent,
+ConsumerImpl::ConsumerImpl(ClientImpl& client, const std::string& topic, const
std::string& subscriptionName,
Review Comment:
> I think it's probably that most method have already state checks at the
beginning.
Yes. If the associated `Client` is expired, the producer or consumer should
not be able to do anything except a `ResultAlreadyClosed`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
