tisonkun commented on code in PR #18132: URL: https://github.com/apache/pulsar/pull/18132#discussion_r1000308578
########## site2/docs/reference-configuration.md: ########## @@ -0,0 +1,9 @@ +--- +id: reference-configuration +title: Pulsar Configuration +sidebar_label: "Pulsar Configuration" +--- + +For a complete list of Pulsar configuration, visit the [Pulsar Reference](http://pulsar.apache.org/reference/#/) website. + + Review Comment: ```suggestion ``` ########## site2/website/sidebars.json: ########## @@ -368,11 +368,7 @@ "items": [ "reference-terminology", "reference-cli-tools", - { - "type": "link", - "href": "https://pulsar.apache.org/reference";, - "label": "Pulsar configuration" - }, + "reference-configuration", Review Comment: After #18101, I think both "reference-cli-tools" and this new "reference-configuration" page redirect to http://pulsar.apache.org/reference? But we can improve the docsify side later... ########## pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdGenerateDocument.java: ########## @@ -107,9 +107,6 @@ private void generateDocument(StringBuilder sb, String module, JCommander obj) { .append("\n```"); sb.append("\n\n"); CmdBase cmdObj = (CmdBase) obj.getObjects().get(0); - for (String s : cmdObj.jcommander.getCommands().keySet()) { - sb.append("* `").append(s).append("`\n"); - } Review Comment: Could you share a preview of diff how these lines affect the final result? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
