[GitHub] [pulsar] SignorMercurio commented on a diff in pull request #18132: [fix][docs] Remove redudant steps in docs gen

Thu, 20 Oct 2022 01:53:49 -0700 


SignorMercurio commented on code in PR #18132:
URL: https://github.com/apache/pulsar/pull/18132#discussion_r1000333036


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdGenerateDocument.java:
##########
@@ -107,9 +107,6 @@ private void generateDocument(StringBuilder sb, String 
module, JCommander obj) {
                     .append("\n```");
             sb.append("\n\n");
             CmdBase cmdObj = (CmdBase) obj.getObjects().get(0);
-            for (String s : cmdObj.jcommander.getCommands().keySet()) {
-                sb.append("* `").append(s).append("`\n");
-            }

Review Comment:
   
![image](https://user-images.githubusercontent.com/32540679/196902992-874c0e0c-498b-4728-b65d-24bf7a6ef5bb.png)
   
   These lists are removed by removing these code. They are redundant because 
we now already have a TOC on the right side.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to