sijie commented on a change in pull request #4262: Delete schema when deleting
inactive topic
URL: https://github.com/apache/pulsar/pull/4262#discussion_r283981932
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java
##########
@@ -1040,6 +1040,21 @@ public void markBatchMessagePublished() {
.putSchemaIfAbsent(id, schema, schemaCompatibilityStrategy);
}
+ @Override
+ public CompletableFuture<SchemaVersion> deleteSchema() {
+ String base = TopicName.get(getName()).getPartitionedTopicName();
+ String id = TopicName.get(base).getSchemaName();
+ SchemaRegistryService schemaRegistryService =
brokerService.pulsar().getSchemaRegistryService();
+ return schemaRegistryService.getSchema(id)
+ .thenCompose(schema -> {
+ if (schema != null) {
+ return schemaRegistryService.deleteSchema(id, "");
Review comment:
should we handle concurrent deletions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
