BewareMyPower commented on code in PR #131:
URL: https://github.com/apache/pulsar-client-cpp/pull/131#discussion_r1035721445
##########
lib/ProducerImpl.cc:
##########
@@ -172,6 +172,8 @@ void ProducerImpl::connectionFailed(Result result) {
void ProducerImpl::handleCreateProducer(const ClientConnectionPtr& cnx, Result
result,
const ResponseData& responseData) {
+ Lock lock(mutex_);
Review Comment:
Could you explain more about the race condition you mentioned in this PR? I
agree it does not affect performance significantly, but it should be reasonable
to use a lock here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
