BewareMyPower commented on code in PR #131:
URL: https://github.com/apache/pulsar-client-cpp/pull/131#discussion_r1036659198
##########
lib/ProducerImpl.cc:
##########
@@ -694,6 +705,8 @@ void ProducerImpl::closeAsync(CloseCallback
originalCallback) {
}
};
+ Lock lock(mutex_);
Review Comment:
Could you use another mutex to synchronize `closeAsync` and
`handleCreatedProducer`? The `mutex_` is already used in other places and it's
not clear why the mutex is required here from the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
