tisonkun commented on code in PR #4932:
URL: https://github.com/apache/pulsar/pull/4932#discussion_r1044043513
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java:
##########
@@ -271,12 +271,7 @@ void runCmd() throws Exception {
}
protected void validateSinkConfigs(SinkConfig sinkConfig) {
- if (sinkConfig.getTenant() == null) {
- sinkConfig.setTenant(PUBLIC_TENANT);
- }
- if (sinkConfig.getNamespace() == null) {
- sinkConfig.setNamespace(DEFAULT_NAMESPACE);
- }
+
org.apache.pulsar.common.functions.Utils.inferMissingArguments(sinkConfig);
Review Comment:
I'm unsure whether we should update other fields except tenant and namespace
if it's not specified.
If we should keep the original logic, then the test case should be updated
since updating has a different codepath.
cc @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
