tisonkun commented on code in PR #4932:
URL: https://github.com/apache/pulsar/pull/4932#discussion_r1044046970
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java:
##########
@@ -271,12 +271,7 @@ void runCmd() throws Exception {
}
protected void validateSinkConfigs(SinkConfig sinkConfig) {
- if (sinkConfig.getTenant() == null) {
- sinkConfig.setTenant(PUBLIC_TENANT);
- }
- if (sinkConfig.getNamespace() == null) {
- sinkConfig.setNamespace(DEFAULT_NAMESPACE);
- }
+
org.apache.pulsar.common.functions.Utils.inferMissingArguments(sinkConfig);
Review Comment:
I tend to keep the original logic since we shouldn't update resources if
it's unspecified.
Correspondingly update tests: 6bb9f1ad7100694963851c47d38c5b62d299e218.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
