michaeljmarshall commented on code in PR #18898:
URL: https://github.com/apache/pulsar/pull/18898#discussion_r1047656463
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1326,7 +1327,9 @@ protected void handleProducer(final CommandProducer
cmdProducer) {
backlogQuotaCheckFuture.thenRun(() -> {
// Check whether the producer will publish encrypted
messages or not
- if ((topic.isEncryptionRequired() ||
encryptionRequireOnProducer) && !isEncrypted) {
+ if ((topic.isEncryptionRequired() ||
encryptionRequireOnProducer)
+ && !isEncrypted
+ && !SystemTopicNames.isSystemTopic(topicName)) {
Review Comment:
If `topic.isEncryptionRequired()` is always `false` for system topics, why
do we need the check on the `topicName` on line 1332?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
