nicoloboschi commented on code in PR #18898:
URL: https://github.com/apache/pulsar/pull/18898#discussion_r1047662308
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1326,7 +1327,9 @@ protected void handleProducer(final CommandProducer
cmdProducer) {
backlogQuotaCheckFuture.thenRun(() -> {
// Check whether the producer will publish encrypted
messages or not
- if ((topic.isEncryptionRequired() ||
encryptionRequireOnProducer) && !isEncrypted) {
+ if ((topic.isEncryptionRequired() ||
encryptionRequireOnProducer)
+ && !isEncrypted
+ && !SystemTopicNames.isSystemTopic(topicName)) {
Review Comment:
the previous condition was: topic requires encryption or producer requested
encryption
if I leave it as is, the `encryptionRequireOnProducer` will be valid also
for system topics and then the `opic.isEncryptionRequired()` would be useless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
