BewareMyPower commented on code in PR #139:
URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1050484205
##########
lib/ConsumerImpl.cc:
##########
@@ -460,6 +476,7 @@ void ConsumerImpl::messageReceived(const
ClientConnectionPtr& cnx, const proto::
return;
}
+ auto redeliveryCount = msg.redelivery_count();
Review Comment:
It seems that we need to pass the `redeliveryCount` to the
`decryptMessageIfNeeded` method before? When the decryption failed,
`unAckedMessageTracker.add(m, redeliveryCount);` should be called. (Though I
didn't find if there is a related test)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
