codelipenghui commented on code in PR #19035:
URL: https://github.com/apache/pulsar/pull/19035#discussion_r1057026841
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursor.java:
##########
@@ -150,9 +150,11 @@ enum IndividualDeletedEntries {
* opaque context
* @param maxPosition
* max position can read
+ * @param skipCondition
+ * predicate of read filter out
*/
void asyncReadEntries(int numberOfEntriesToRead, ReadEntriesCallback
callback, Object ctx,
- PositionImpl maxPosition);
+ PositionImpl maxPosition, Predicate<PositionImpl>
skipCondition);
Review Comment:
It's better to add a new method.
I mean, we'd better not change the existing API directly.
This class is annotated with
```
@InterfaceAudience.LimitedPrivate
@InterfaceStability.Stable
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
