mattisonchao commented on code in PR #19035:
URL: https://github.com/apache/pulsar/pull/19035#discussion_r1058704402
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java:
##########
@@ -57,13 +61,13 @@ public static OpReadEntry create(ManagedCursorImpl cursor,
PositionImpl readPosi
maxPosition = PositionImpl.LATEST;
}
op.maxPosition = maxPosition;
+ op.skipCondition = skipCondition;
op.ctx = ctx;
op.nextReadPosition = PositionImpl.get(op.readPosition);
return op;
}
- @Override
- public void readEntriesComplete(List<Entry> returnedEntries, Object ctx) {
+ void internalReadEntriesComplete(List<Entry> returnedEntries, Object ctx,
PositionImpl lastPosition) {
Review Comment:
I'm not sure if it is good to extend this method because we defined a
parameter named `context`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
