BewareMyPower commented on code in PR #19031:
URL: https://github.com/apache/pulsar/pull/19031#discussion_r1058125642
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java:
##########
@@ -267,10 +194,9 @@ private CompletableFuture<Void>
doIndividualAck(MessageIdImpl messageId, Map<Str
}
- private CompletableFuture<Void> doIndividualAckAsync(MessageIdImpl
messageId) {
+ private void doIndividualAckAsync(MessageIdImpl messageId) {
Review Comment:
The current names of these two "Async" methods are confusing. I will rename
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
