BewareMyPower commented on code in PR #19031:
URL: https://github.com/apache/pulsar/pull/19031#discussion_r1058714922
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java:
##########
@@ -129,121 +124,53 @@ public boolean isDuplicate(MessageId messageId) {
}
@Override
- public CompletableFuture<Void> addListAcknowledgment(List<MessageId>
messageIds,
- AckType ackType,
Map<String, Long> properties) {
- if (AckType.Cumulative.equals(ackType)) {
- if (consumer.isAckReceiptEnabled()) {
- Set<CompletableFuture<Void>> completableFutureSet = new
HashSet<>();
- messageIds.forEach(messageId ->
-
completableFutureSet.add(addAcknowledgment((MessageIdImpl) messageId, ackType,
properties)));
- return FutureUtil.waitForAll(new
ArrayList<>(completableFutureSet));
+ public CompletableFuture<Void> addListAcknowledgment(List<MessageIdImpl>
messageIds,
Review Comment:
`AcknowledgmentsGroupingTracker` is not marked with any `InterfaceStability`
annotation like `Stable` and `Evolving`. The `pulsar-client-original` module
contains classes as the "internal implementations" so that new classes and
interfaces were added very casually. If we care much about the breaking changes
of these "internal implementations", the code would be very hard to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
