erichare commented on code in PR #81:
URL:
https://github.com/apache/pulsar-client-python/pull/81#discussion_r1063566322
##########
pulsar/__init__.py:
##########
@@ -62,6 +62,11 @@
from datetime import timedelta
+# Get the pulsar version from version.txt
+with open("version.txt") as f:
Review Comment:
Thanks @tisonkun . Do you mind taking a quick look at:
https://github.com/apache/pulsar-client-python/pull/81/commits/da872e082105e9f28e9d77e71525171243def0f1
- is this the right approach (similar to what is done in the setup.py file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]