BewareMyPower commented on code in PR #81:
URL: 
https://github.com/apache/pulsar-client-python/pull/81#discussion_r1065533705


##########
pulsar/__init__.py:
##########
@@ -62,6 +62,11 @@
 from datetime import timedelta
 
 
+# Get the pulsar version from version.txt
+with open("version.txt") as f:

Review Comment:
   The root cause is `version.txt` is not included in the Python wheel. I just 
checked the installed wheel by this patch:
   
   ```bash
   $ ls /usr/local/lib/python3.8/dist-packages/pulsar
   __init__.py  __pycache__  exceptions.py  functions  schema
   ```
   
   ```



##########
pulsar/__init__.py:
##########
@@ -62,6 +62,11 @@
 from datetime import timedelta
 
 
+# Get the pulsar version from version.txt
+with open("version.txt") as f:

Review Comment:
   The root cause is `version.txt` is not included in the Python wheel. I just 
checked the installed wheel by this patch:
   
   ```bash
   $ ls /usr/local/lib/python3.8/dist-packages/pulsar
   __init__.py  __pycache__  exceptions.py  functions  schema
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to