yaalsn commented on code in PR #19157:
URL: https://github.com/apache/pulsar/pull/19157#discussion_r1065275959
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1599,6 +1599,12 @@ public void openLedgerComplete(ManagedLedger ledger,
Object ctx) {
.exceptionally((ex) -> {
log.warn("Replication or dedup
check failed."
+ " Removing topic from
topics list {}, {}", topic, ex);
+
persistentTopic.getTransactionBuffer()
+ .closeAsync()
+ .exceptionally(t -> {
+ log.error("[{}] Close
transactionBuffer failed", topic, t);
+ return null;
Review Comment:
Do you know if we need to return here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
