[GitHub] [pulsar] tjiuming commented on a diff in pull request #19157: [fix][broker] Close transactionBuffer after MessageDeduplication#checkStatus failed

Tue, 10 Jan 2023 01:31:01 -0800 


tjiuming commented on code in PR #19157:
URL: https://github.com/apache/pulsar/pull/19157#discussion_r1065537413


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1599,6 +1599,12 @@ public void openLedgerComplete(ManagedLedger ledger, 
Object ctx) {
                                         .exceptionally((ex) -> {
                                             log.warn("Replication or dedup 
check failed."
                                                     + " Removing topic from 
topics list {}, {}", topic, ex);
+                                            
persistentTopic.getTransactionBuffer()
+                                                    .closeAsync()
+                                                    .exceptionally(t -> {
+                                                        log.error("[{}] Close 
transactionBuffer failed", topic, t);
+                                                        return null;

Review Comment:
   CompletableFuture#exceptionally() requires a `Function` arg
   
![image](https://user-images.githubusercontent.com/95597048/211513471-66e4d4bb-3b24-4ac5-9d8c-9866b4195144.png)
   and `Function` requires a return value.
   
![image](https://user-images.githubusercontent.com/95597048/211513648-f07c6ec6-29ea-46bf-aa6b-18f26ca63ae4.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to