Anonymitaet commented on a change in pull request #4374: [rest] improve 
clusters rest endpoint by documenting the endpoints with more swagger 
annotations
URL: https://github.com/apache/pulsar/pull/4374#discussion_r287594709
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java
 ##########
 @@ -108,12 +132,39 @@ public ClusterData getCluster(@PathParam("cluster") 
String cluster) {
 
     @PUT
     @Path("/{cluster}")
-    @ApiOperation(value = "Provisions a new cluster. This operation requires 
Pulsar super-user privileges.", notes = "The name cannot contain '/' 
characters.")
-    @ApiResponses(value = { @ApiResponse(code = 204, message = "Cluster has 
been created"),
+    @ApiOperation(
+        value = "Create a new cluster. ",
+        notes = "This operation requires Pulsar super-user privileges, and the 
name cannot contain '/' characters."
 
 Review comment:
   ```suggestion
           notes = "This operation requires Pulsar superuser privileges, and 
the name cannot contain the " / " character."
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to