Anonymitaet commented on a change in pull request #4374: [rest] improve 
clusters rest endpoint by documenting the endpoints with more swagger 
annotations
URL: https://github.com/apache/pulsar/pull/4374#discussion_r287592454
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java
 ##########
 @@ -87,10 +97,24 @@
 
     @GET
     @Path("/{cluster}")
-    @ApiOperation(value = "Get the configuration data for the specified 
cluster.", response = ClusterData.class)
-    @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have 
admin permission"),
-            @ApiResponse(code = 404, message = "Cluster doesn't exist") })
-    public ClusterData getCluster(@PathParam("cluster") String cluster) {
+    @ApiOperation(
+        value = "Get the configuration data for the specified cluster.",
+        response = ClusterData.class,
+        notes = "This operation requires Pulsar super-user privileges."
 
 Review comment:
   ```suggestion
           notes = "This operation requires Pulsar superuser privileges."
   ```
   
   superuser, not super-user

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to