tisonkun commented on code in PR #18550:
URL: https://github.com/apache/pulsar/pull/18550#discussion_r1065521005
##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java:
##########
@@ -2988,57 +2991,88 @@ public void testManagedLedgerWithReadEntryTimeOut()
throws Exception {
Review Comment:
Does the original test case fail with your change? If not, I suggest you add
a new case instead of modifying an existing case. Otherwise, it looks like a
breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
