BewareMyPower commented on code in PR #169: URL: https://github.com/apache/pulsar-client-cpp/pull/169#discussion_r1066673285
########## tests/InterceptorsTest.cc: ########## @@ -0,0 +1,157 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#include <gtest/gtest.h> +#include <pulsar/Client.h> +#include <pulsar/ProducerInterceptor.h> + +#include <utility> + +#include "HttpHelper.h" +#include "Latch.h" + +static const std::string serviceUrl = "pulsar://localhost:6650"; +static const std::string adminUrl = "http://localhost:8080/";; + +using namespace pulsar; + +class TestInterceptor : public ProducerInterceptor { + public: + explicit TestInterceptor(Latch latch) : latch_(std::move(latch)) {} + + Message beforeSend(const Producer& producer, const Message& message) override { + return MessageBuilder().setProperty("key", "set").setContent(message.getDataAsString()).build(); + } + + void onSendAcknowledgement(const Producer& producer, Result result, const Message& message, + const MessageId& messageID) override { + ASSERT_EQ(result, ResultOk); + auto properties = message.getProperties(); + if (properties.find("key") != properties.end() && properties["key"] == "set") { + latch_.countdown(); + } + } + + private: + Latch latch_; +}; + +class ExceptionInterceptor : public ProducerInterceptor { + public: + explicit ExceptionInterceptor(Latch latch) : latch_(std::move(latch)) {} + + Message beforeSend(const Producer& producer, const Message& message) override { + latch_.countdown(); + throw std::runtime_error("expected exception"); + } + + void onSendAcknowledgement(const Producer& producer, Result result, const Message& message, + const MessageId& messageID) override { + latch_.countdown(); + throw std::runtime_error("expected exception"); + } + + private: + Latch latch_; +}; + +class PartitionsChangeInterceptor : public ProducerInterceptor { + public: + explicit PartitionsChangeInterceptor(Latch latch) : latch_(std::move(latch)) {} + + Message beforeSend(const Producer& producer, const Message& message) override { return message; } + + void onSendAcknowledgement(const Producer& producer, Result result, const Message& message, + const MessageId& messageID) override {} + + void onPartitionsChange(const std::string& topicName, int partitions) override { + ASSERT_EQ(partitions, 3); + latch_.countdown(); + } + + private: + Latch latch_; +}; + +TEST(InterceptorsTest, testProducerInterceptor) { + const std::string topic = "InterceptorsTest-testProducerInterceptor-" + std::to_string(time(nullptr)); + + Latch latch(1); + + Client client(serviceUrl); + ProducerConfiguration conf; + conf.intercept({std::make_shared<TestInterceptor>(latch)}); + Producer producer; + client.createProducer(topic, conf, producer); + + Message msg = MessageBuilder().setContent("content").build(); + Result result = producer.send(msg); + ASSERT_EQ(result, ResultOk); + + latch.wait(std::chrono::seconds(5)); Review Comment: You should check the returned value of `wait`, as well as the received message, which should have set the "key" property through the interceptor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
