BewareMyPower commented on code in PR #169: URL: https://github.com/apache/pulsar-client-cpp/pull/169#discussion_r1066698932
########## include/pulsar/ProducerConfiguration.h: ########## @@ -532,6 +533,10 @@ class PULSAR_PUBLIC ProducerConfiguration { */ ProducerAccessMode getAccessMode() const; + ProducerConfiguration& intercept(const std::initializer_list<ProducerInterceptorPtr> interceptors); Review Comment: I just missed the code here. Generally, `std::initializer_list` should be passed by value. BTW, the `const` could be removed. See `std::vector`'s 10th constructor: https://en.cppreference.com/w/cpp/container/vector/vector -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org