shibd commented on code in PR #157:
URL: https://github.com/apache/pulsar-client-cpp/pull/157#discussion_r1069423672
##########
include/pulsar/Result.h:
##########
@@ -94,6 +94,7 @@ enum Result
ResultInterrupted, /// Interrupted while waiting to dequeue
ResultDisconnected, /// Client connection has been disconnected
+ ResultNotFound /// The generic was not found
Review Comment:
This means the requested resource/data was not found. Currently used as HTTP
request 404, It can also be used as other scenarios. So define it as generic
```c++
case CURLE_HTTP_RETURNED_ERROR:
LOG_ERROR("Response failed for url " << completeUrl << ".
Error Code " << res);
if (response_code == 404) {
retResult = ResultNotFound;
} else {
retResult = ResultConnectError;
}
break;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
