BewareMyPower commented on code in PR #157:
URL: https://github.com/apache/pulsar-client-cpp/pull/157#discussion_r1073576266
##########
tests/ClientTest.cc:
##########
@@ -305,6 +305,7 @@ TEST(ClientTest, testCloseClient) {
auto t0 = std::chrono::steady_clock::now();
while ((std::chrono::steady_clock::now() - t0) <
std::chrono::microseconds(i)) {
}
+ sleep(1);
Review Comment:
Please move it into another PR if you want to fix the flaky test. BTW,
sleeping 1 second is unacceptable here because it's in a 1000 times loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
