blankensteiner commented on code in PR #133:
URL: https://github.com/apache/pulsar-dotpulsar/pull/133#discussion_r1073277787
##########
src/DotPulsar/Internal/NotReadyChannel.cs:
##########
@@ -35,7 +35,7 @@ public ValueTask<IMessage<TMessage>>
Receive(CancellationToken cancellationToken
=> throw GetException();
public Task Send(MessageMetadata metadata, ReadOnlySequence<byte> payload,
TaskCompletionSource<BaseCommand> responseTcs, CancellationToken
Review Comment:
Let's merge lines 37 and 38
##########
src/DotPulsar/Internal/Abstractions/IProducerChannel.cs:
##########
@@ -23,6 +23,6 @@ namespace DotPulsar.Internal.Abstractions;
public interface IProducerChannel : IAsyncDisposable
{
Task Send(MessageMetadata metadata, ReadOnlySequence<byte> payload,
TaskCompletionSource<BaseCommand> responseTcs, CancellationToken
Review Comment:
Let's merge lines 25 and 26
##########
tests/DotPulsar.Tests/IntegrationFixture.cs:
##########
@@ -52,13 +52,13 @@ public IntegrationFixture(IMessageSink messageSink)
};
var arguments = "\"" +
- $"bin/pulsar tokens create-secret-key --output {SecretKeyPath} &&
" +
Review Comment:
I like the reformatting, but wonder if VS will respect this or change it
back when auto-formatting?
##########
tests/DotPulsar.Tests/ProducerTests.cs:
##########
@@ -188,9 +188,9 @@ public async Task
RoundRobinPartition_WhenSendMessages_ThenGetMessagesFromPartit
private IPulsarClient CreateClient()
=> PulsarClient
- .Builder()
- .Authentication(AuthenticationFactory.Token(ct =>
ValueTask.FromResult(_fixture.CreateToken(Timeout.InfiniteTimeSpan))))
- .ExceptionHandler(ec => _testOutputHelper.WriteLine($"Exception:
{ec.Exception}"))
- .ServiceUrl(_fixture.ServiceUrl)
- .Build();
+ .Builder()
Review Comment:
Will VS move this back?
##########
tests/DotPulsar.Tests/TokenTests.cs:
##########
@@ -131,18 +131,18 @@ public async Task
TokenSupplier_WhenTokenSupplierReturnValidToken_ShouldStayConn
private IPulsarClient CreateClient(Func<CancellationToken,
ValueTask<string>> tokenSupplier)
=> PulsarClient
- .Builder()
- .Authentication(AuthenticationFactory.Token(tokenSupplier))
- .ExceptionHandler(ec => _testOutputHelper.WriteLine($"Exception:
{ec.Exception}"))
- .ServiceUrl(_fixture.ServiceUrl)
- .Build();
+ .Builder()
Review Comment:
Will VS move this back?
##########
tests/DotPulsar.Tests/Internal/AsyncQueueWithCursorTests.cs:
##########
@@ -436,7 +436,7 @@ public QueueItem(int number)
Number = number;
}
- public void Dispose() {}
Review Comment:
Let's have an empty space between line 439 and 440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
