entvex commented on code in PR #133:
URL: https://github.com/apache/pulsar-dotpulsar/pull/133#discussion_r1073507049
##########
tests/DotPulsar.Tests/ProducerTests.cs:
##########
@@ -188,9 +188,9 @@ public async Task
RoundRobinPartition_WhenSendMessages_ThenGetMessagesFromPartit
private IPulsarClient CreateClient()
=> PulsarClient
- .Builder()
- .Authentication(AuthenticationFactory.Token(ct =>
ValueTask.FromResult(_fixture.CreateToken(Timeout.InfiniteTimeSpan))))
- .ExceptionHandler(ec => _testOutputHelper.WriteLine($"Exception:
{ec.Exception}"))
- .ServiceUrl(_fixture.ServiceUrl)
- .Build();
+ .Builder()
Review Comment:
VS will respect this change. Tested in VS2022
##########
tests/DotPulsar.Tests/TokenTests.cs:
##########
@@ -131,18 +131,18 @@ public async Task
TokenSupplier_WhenTokenSupplierReturnValidToken_ShouldStayConn
private IPulsarClient CreateClient(Func<CancellationToken,
ValueTask<string>> tokenSupplier)
=> PulsarClient
- .Builder()
- .Authentication(AuthenticationFactory.Token(tokenSupplier))
- .ExceptionHandler(ec => _testOutputHelper.WriteLine($"Exception:
{ec.Exception}"))
- .ServiceUrl(_fixture.ServiceUrl)
- .Build();
+ .Builder()
Review Comment:
VS will respect this change. Tested in VS2022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
