[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #170: [feature] Support set ServiceUrlProvider when create client.

[GitBox]

BewareMyPower commented on code in PR #170:
URL: https://github.com/apache/pulsar-client-cpp/pull/170#discussion_r1080749572


##########
lib/ServiceNameResolver.h:
##########
@@ -29,29 +29,33 @@ namespace pulsar {
 class ServiceNameResolver {

Review Comment:
   Add a `#include <memory>` to this file for `std::make_shared`. The 
compilation did not fail because the `.cc` files that include this header 
already include `<memory>`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org