BewareMyPower commented on code in PR #170:
URL: https://github.com/apache/pulsar-client-cpp/pull/170#discussion_r1080753416
##########
lib/ClientImpl.cc:
##########
@@ -497,6 +497,20 @@ void ClientImpl::getPartitionsForTopicAsync(const
std::string& topic, GetPartiti
std::placeholders::_2, topicName, callback));
}
+Result ClientImpl::updateServiceUrl(const std::string& serviceUrl) {
+ LOG_INFO("Updating service URL to " << serviceUrl);
+
+ try {
+ serviceNameResolver_.updateServiceUrl(serviceUrl);
+ lookupServicePtr_->updateServiceUrl(serviceUrl);
Review Comment:
Actually we don't need to add `updateServiceUrl` method to `LookupService`
because in C++ client, all `LookupService` implementations just call
`serviceNameResolver_.updateServiceUrl(serviceUrl);`.
Unlike Java client, `HttpLookupService` uses a `HttpClient` class that
accepts a service URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
