BewareMyPower commented on code in PR #129:
URL: https://github.com/apache/pulsar-client-cpp/pull/129#discussion_r1080906832
##########
include/pulsar/ClientConfiguration.h:
##########
@@ -64,25 +64,25 @@ class PULSAR_PUBLIC ClientConfiguration {
*
* @param timeout the timeout after which the operation will be considered
as failed
*/
- ClientConfiguration& setOperationTimeoutSeconds(int timeout);
+ ClientConfiguration& setOperationTimeoutSeconds(int32_t timeout);
Review Comment:
I think we should open another PR to change the types of these existing
methods. Thought it won't be a breaking change to replace `int` with `int32_t`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
