BewareMyPower commented on code in PR #129:
URL: https://github.com/apache/pulsar-client-cpp/pull/129#discussion_r1080910162
##########
lib/HandlerBase.h:
##########
@@ -113,13 +113,14 @@ class HandlerBase {
enum State
{
- NotStarted,
- Pending,
- Ready,
- Closing,
- Closed,
- Failed,
- Producer_Fenced
+ NotStarted, // Not initialized, in Java client:
HandlerState.State.Uninitialized
+ Pending, // Client connecting to broker, in Java client:
HandlerState.State.Connecting
+ Ready, // Handler is being used, in Java client:
HandlerState.State.Ready
+ Closing, // Close cmd has been sent to broker, in Java
client: HandlerState.State.Closing
+ Closed, // Broker acked the close, in Java client:
HandlerState.State.Closed
+ Failed, // Handler is failed, in Java client:
HandlerState.State.Failed
+ Producer_Fenced, // The producer has been fenced by the broker
Review Comment:
Why not use a name `ProducerFenced`? It's better to keep the variable naming
style consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
