BewareMyPower opened a new pull request, #183: URL: https://github.com/apache/pulsar-client-cpp/pull/183
### Motivation https://github.com/apache/pulsar-client-cpp/pull/182 fixes the Wireshark build process on macOS. However, it breaks the compatibility with some Wireshark distributions like the default Wireshark 3.2.3 on Ubuntu 20.04. The reason is some Wireshark distributions use `config.h` to record the versions, while other might use `ws_version.h`. See https://listman.redhat.com/archives/libvir-list/2020-September/msg00377.html for a similar fix. ### Modifications Try to find the `ws_version.h` first, if it's not found, find the `config.h`. To be more user friendly: - Separate the dissector from the whole project so that we can build the dissector without building the Pulsar C++ client. - Refactor the README of the Wireshark dissector by focusing on how to use. ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [ ] `doc-not-needed` (Please explain why) - [x] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
