Demogorgon314 commented on code in PR #183:
URL: https://github.com/apache/pulsar-client-cpp/pull/183#discussion_r1095308556
##########
wireshark/CMakeLists.txt:
##########
@@ -17,67 +17,46 @@
# under the License.
#
-set(CMAKE_CXX_FLAGS "-O3 -g ${CMAKE_CXX_FLAGS}")
+cmake_minimum_required(VERSION 3.7)
+project(pulsar-cpp-wireshark)
-MESSAGE(STATUS "Use WIRESHARK_BUILD_TYPE: ${CMAKE_BUILD_TYPE}")
+set(CMAKE_CXX_STANDARD 11)
Review Comment:
We can use a command to find the `WIRESHARK_INCLUDE_PATH` for M1 macOS.
```
if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND CMAKE_SYSTEM_PROCESSOR STREQUAL
"arm64")
execute_process(COMMAND sh -c "find $(brew --prefix)/Cellar/wireshark
-name 'include' -type d"
OUTPUT_STRIP_TRAILING_WHITESPACE
OUTPUT_VARIABLE
WIRESHARK_INCLUDE_PATH)
endif()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
