michaeljmarshall commented on code in PR #19377:
URL: https://github.com/apache/pulsar/pull/19377#discussion_r1092372362
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java:
##########
@@ -214,10 +214,10 @@ public class ElasticSearchConfig implements Serializable {
@FieldDoc(
required = false,
- defaultValue = "5",
- help = "Idle connection timeout to prevent a read timeout."
+ defaultValue = "30000",
+ help = "Idle connection timeout to prevent a connection timeouts."
)
- private int connectionIdleTimeoutInMs = 5;
+ private int connectionIdleTimeoutInMs = 30000;
Review Comment:
I think it'd be fine to let the connection get closed in that scenario. My
main goal here is to make sure we have working defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
