michaeljmarshall commented on code in PR #19377:
URL: https://github.com/apache/pulsar/pull/19377#discussion_r1092560076


##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/client/RestClient.java:
##########
@@ -83,7 +83,6 @@ public RestClient(ElasticSearchConfig elasticSearchConfig, 
BulkProcessor.Listene
         // idle+expired connection evictor thread
         this.executorService = Executors.newSingleThreadScheduledExecutor();
         this.executorService.scheduleAtFixedRate(() -> {
-                    configCallback.connectionManager.closeExpiredConnections();
                     configCallback.connectionManager.closeIdleConnections(

Review Comment:
   @lhotari - that was not the case in the AKS cluster that I was testing with 
as of yesterday. When I tried to override the settings using 
https://kubernetes.io/docs/tasks/administer-cluster/sysctl-cluster/#setting-sysctls-for-a-pod,
 I got an error because overriding `net.ipv4.tcp_keepalive_time = 300` is 
considered "unsafe" by default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to